feat!: orjson instead of simplejson to load and save JSON objects #134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
This pull request replaces
simplejson
byorjson
.The previous JSON files generated by
simplejson
are compatible withorjson
and, indeed, they seem equal to me, so no breaking changes in this aspect.However, the API or
orjson
is not compatible with the Python nativejson
library, soorjson
is required to use Lab after this change meanwhilesimplejson
was optional.In a performance perspective,
orjson
is around 4x faster (without SWAP usage) but it uses more RAM (around the double of RAM, not a problem in the most use cases). More benchmarks would be needed in your side before merging this pull request however.Thanks.