Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: orjson instead of simplejson to load and save JSON objects #134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Martin1887
Copy link
Contributor

Hello.

This pull request replaces simplejson by orjson.

The previous JSON files generated by simplejson are compatible with orjson and, indeed, they seem equal to me, so no breaking changes in this aspect.

However, the API or orjson is not compatible with the Python native json library, so orjson is required to use Lab after this change meanwhile simplejson was optional.

In a performance perspective, orjson is around 4x faster (without SWAP usage) but it uses more RAM (around the double of RAM, not a problem in the most use cases). More benchmarks would be needed in your side before merging this pull request however.

Thanks.

@jendrikseipp
Copy link
Collaborator

Great, thanks! I'll test when I find the time. Maybe you can try fixing the tests in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants