Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controllers): remove duplicate function #140

Merged
merged 2 commits into from
Sep 18, 2024
Merged

fix(controllers): remove duplicate function #140

merged 2 commits into from
Sep 18, 2024

Conversation

domire8
Copy link
Member

@domire8 domire8 commented Sep 18, 2024 •
edited
Loading

Description

The get_lifecycle_state function is now already defined in the controller interface since this commit. No need to define it again ourselves.

Review guidelines

Estimated Time of Review: 3 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

bpapaspyros
bpapaspyros approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@bpapaspyros bpapaspyros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@domire8 domire8 merged commit 6d2a01b into main Sep 18, 2024
4 checks passed
@domire8 domire8 deleted the feat/new-base branch September 18, 2024 08:03
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpapaspyros bpapaspyros bpapaspyros approved these changes

@eeberhard eeberhard Awaiting requested review from eeberhard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domire8 @bpapaspyros