Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: support generic inputs and outputs in controllers #150

Merged

Conversation

bpapaspyros
Copy link
Member

@bpapaspyros bpapaspyros commented Oct 3, 2024

Description

This PR adds support for generic outputs in controllers. Similarly to #145, we use compile-time data type inference to make sure that custom (ROS) types are 1) added to the output map generically, 2) are directly published when write_output is invoked.

Review guidelines

Estimated Time of Review: 10 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@bpapaspyros bpapaspyros requested a review from domire8 October 3, 2024 11:13
@bpapaspyros bpapaspyros self-assigned this Oct 3, 2024
@bpapaspyros
Copy link
Member Author

@domire8 just about to write the corresponding issue and update the descriptions, but this is my draft for the time being.

@bpapaspyros bpapaspyros marked this pull request as ready for review October 4, 2024 07:08
@domire8 domire8 force-pushed the feat/generic_controller_outputs branch from ec703d4 to 5307e2c Compare October 4, 2024 08:36
@domire8 domire8 changed the title feat!: support generic outputs in controllers feat!: support generic inputs and outputs in controllers Oct 4, 2024
Copy link
Member

@domire8 domire8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bpapaspyros bpapaspyros merged commit c1c0a57 into feat/generic_pubsub_dev Oct 4, 2024
3 of 4 checks passed
@bpapaspyros bpapaspyros deleted the feat/generic_controller_outputs branch October 4, 2024 10:32
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants