Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): correctly go through shutdown sequence #157

Merged
merged 3 commits into from
Oct 9, 2024
Merged

fix(components): correctly go through shutdown sequence #157

merged 3 commits into from
Oct 9, 2024

Conversation

domire8
Copy link
Member

@domire8 domire8 commented Oct 9, 2024 •
edited
Loading

Description

Due to missing switch cases in Python we have to manually trigger everything correctly.

Review guidelines

Estimated Time of Review: 4 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

bpapaspyros
bpapaspyros previously approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@bpapaspyros bpapaspyros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me to the extent that I have followed this issue

eeberhard
eeberhard previously approved these changes Oct 9, 2024
View reviewed changes
@domire8 domire8 dismissed stale reviews from eeberhard and bpapaspyros via 16a18ea October 9, 2024 11:30
@domire8 domire8 merged commit cbb682f into main Oct 9, 2024
4 checks passed
@domire8 domire8 deleted the fix/lifecycle-shutdown branch October 9, 2024 11:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eeberhard eeberhard eeberhard approved these changes

@bpapaspyros bpapaspyros bpapaspyros left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domire8 @bpapaspyros @eeberhard