-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add TF listener and lookup TF helpers in BaseControllerInterface #173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there even a modification compared to modulo component interface?
no, just |
nice, that triggers a problem actually. If someone tried |
yes, sure enough that gives a seg. fault |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
This PR solves the issue by replicating the TF listener functions from
ComponentInterface
.Review guidelines
Estimated Time of Review: 8 minutes
Checklist before merging: