Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): use parent node for tf listener (cpp) #189

Merged
merged 4 commits into from
Mar 11, 2025
Merged

feat(components): use parent node for tf listener (cpp) #189

merged 4 commits into from
Mar 11, 2025

Conversation

domire8
Copy link
Member

@domire8 domire8 commented Jan 31, 2025 •
edited
Loading

Description

This PR solves the issue by passing in the parent node interfaces to avoid the creation of a separate node for the tf listener

Review guidelines

Estimated Time of Review: 3 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@domire8 domire8 linked an issue Jan 31, 2025 that may be closed by this pull request
Construction of transform listener #187
Closed
eeberhard
eeberhard previously approved these changes Jan 31, 2025
View reviewed changes
bpapaspyros
bpapaspyros previously approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@bpapaspyros bpapaspyros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me if it has already been tested, otherwise perhaps we keep it back for a moment to test (?)

@domire8
Copy link
Member Author

domire8 commented Feb 5, 2025

It is tested, the special transform_listener_xx disappear indeed but I'm just holding it back because we might want to tweak it in Python too

@domire8 domire8 dismissed stale reviews from bpapaspyros and eeberhard via aab567c March 11, 2025 10:34
@domire8
Copy link
Member Author

domire8 commented Mar 11, 2025

I tested this again and got some errors in python sometimes that I don't want to investigate further at the moment so I will not change anything on that side for now

@domire8 domire8 changed the title feat: use parent node for tf listener feat(components): use parent node for tf listener Mar 11, 2025
domire8
domire8 commented Mar 11, 2025
View reviewed changes
@domire8 domire8 changed the title feat(components): use parent node for tf listener feat(components): use parent node for tf listener (cpp) Mar 11, 2025
@domire8 domire8 merged commit 6029666 into main Mar 11, 2025
4 checks passed
@domire8 domire8 deleted the feat/tf-node branch March 11, 2025 10:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpapaspyros bpapaspyros bpapaspyros approved these changes

@eeberhard eeberhard eeberhard left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Construction of transform listener
3 participants
@domire8 @bpapaspyros @eeberhard