Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: change test workflow to docker build #55

Merged
merged 4 commits into from
Sep 27, 2023
Merged

ci: change test workflow to docker build #55

merged 4 commits into from
Sep 27, 2023

Conversation

domire8
Copy link
Member

@domire8 domire8 commented Sep 27, 2023 •
edited
Loading

Description

Would be nice to get that in before #54

Review guidelines

Estimated Time of Review: 5 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@domire8 domire8 requested a review from eeberhard September 27, 2023 10:58
@domire8 domire8 changed the base branch from main to develop September 27, 2023 10:58
@domire8 domire8 requested a review from jjenscodee September 27, 2023 11:25
eeberhard
eeberhard approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification 👍

@domire8 domire8 merged commit fbc0347 into develop Sep 27, 2023
4 checks passed
@domire8 domire8 deleted the ci/tests branch September 27, 2023 12:45
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eeberhard eeberhard eeberhard approved these changes

@jjenscodee jjenscodee Awaiting requested review from jjenscodee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domire8 @eeberhard