Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade artifact-upload to fix arm64 build? #421

Closed
wants to merge 8 commits into from

Conversation

danielhollas
Copy link
Contributor

The arm64 build is failing on artifact-upload step. I am not sure if that is the consequence of the bump of actions/artifact-upload to v4, or something is wrong with our self-hosted runners. Let's see if downgrading helps.

@danielhollas danielhollas changed the title WIP: Downgrade artifact-upload to fix arm64 build? Downgrade artifact-upload to fix arm64 build? Dec 16, 2023
@danielhollas danielhollas marked this pull request as ready for review December 16, 2023 21:56
@danielhollas
Copy link
Contributor Author

Looks like we will have to downgrade the actions/upload-artifact back to v3 since the v4 does not work on our self-hosted runner yet.

In the release notes, they mention this:

On self hosted runners, additional firewall rules may be required.

cc @mbercx @unkcpz

Before this is debugged, I'd suggest to merge this to get us working again.

@unkcpz
Copy link
Member

unkcpz commented Dec 18, 2023

Thanks a lot for taking care of artifact-upload action. If it break the github workflow, we have to postpone the update of it.
And I'll work on not uploading the artifact this week.

I'm a bit curious why the PR that bumped the artifact-upload didn't have a failed test?
I approve this and I'll let you merge it with a proper commit message, thanks.

unkcpz
unkcpz previously approved these changes Dec 18, 2023
@unkcpz
Copy link
Member

unkcpz commented Dec 18, 2023

One more thing that needs to be noticed is running on @mbercx's machine may not the final solution, since he found somehow it maybe the reason that caused his daily AiiDA work environment break.

@unkcpz unkcpz dismissed their stale review December 18, 2023 10:39

The merge-base changed after approval.

@danielhollas
Copy link
Contributor Author

Closed in favour of #423

@danielhollas danielhollas deleted the downgrade-artifact-upload branch July 16, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants