Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiida-core to 2.4.3 to include the fix of mpi setup #427

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Jan 17, 2024

No description provided.

@unkcpz
Copy link
Member Author

unkcpz commented Jan 17, 2024

Need to wait for aiida-core docker stack is available. This is one small reason I don't like using conda to install the core dependencies, with pypi we can always get things immediately.

@danielhollas
Copy link
Contributor

Need to wait for aiida-core docker stack is available. This is one small reason I don't like using conda to install the core dependencies, with pypi we can always get things immediately.

True, but the couple days wait is not worth it IMHO. Also, installing via pip would most likely increase the image size since conda is more efficient for bundling non-Python dependencies.

@unkcpz unkcpz force-pushed the bump/aiida-core-2.4.3 branch from 2cbbf73 to a3d3f43 Compare January 18, 2024 10:39
@unkcpz
Copy link
Member Author

unkcpz commented Jan 18, 2024

True, but the couple days wait is not worth it IMHO.

Okay, not hard to have conda feedstock update manually. Let's keep on using conda, we live quite well with it.

Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yakutovicha can you please test that this fixes your MPI issues?
(image aiidalab/full-stack:pr-427)

@unkcpz
Copy link
Member Author

unkcpz commented Jan 22, 2024

Discussed with @yakutovicha on slack, we agree on get this merged and ask @cpignedoli test on the new image.

@unkcpz unkcpz merged commit 47dc4e3 into main Jan 22, 2024
25 checks passed
@unkcpz unkcpz deleted the bump/aiida-core-2.4.3 branch January 22, 2024 22:44
unkcpz added a commit that referenced this pull request Jan 23, 2024
aiida-core 2.4.3 include the fix aiidateam/aiida-core#6218 for correctly setup the mpi option of code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants