-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changing the labels of periodicity widget #933
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
=======================================
Coverage 67.85% 67.85%
=======================================
Files 110 110
Lines 6206 6206
=======================================
Hits 4211 4211
Misses 1995 1995
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We suggest the following labels: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AndresOrtegaGuerrero , were there follow up discussions to move slightly away from
#933 ?
otherwise I would stick to what was decided there if space allows
I would keep (surfaces, slabs, ...) to leave it open to other cases we do not mention. |
OK from my side. Automatic detection of periodicity using the function suggested by @giovannipizzi (P1 https://github.com/orgs/aiidalab/projects/17/views/1?pane=issue&itemId=88010088) will follow as a separate PR |
I would add NOTE: in bold before the bullet points |
@cpignedoli @giovannipizzi Like this figure above is correct ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reflects what we discussed so far.
Just to be sure, both requirements are needed (both being the 3rd lattice vector, and being along z), right? OK to keep as it is and if people complain, we make it even clearer |
This PR changes the labels of the periodicity options widget as the following