-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set condition for update label if SOC if False #940
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #940 +/- ##
==========================================
- Coverage 68.40% 68.38% -0.03%
==========================================
Files 110 110
Lines 6096 6098 +2
==========================================
Hits 4170 4170
- Misses 1926 1928 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay @AndresOrtegaGuerrero. LGTM! Thanks for the fix 🙂
One general comment is the use of "band" instead of "bands", which we do this in many places, e.g. BandPdosPlotly
. I suggest we switch to "bands" across the board, if possible, unless we speak of a single band. TBD 🙂
yeah , I agree, in the other PR i will change for BandsPdosPlotly , but |
This PR addresses a bug related to the updating of labels for SOC (Spin-Orbit Coupling) calculations. The logic has been refined to ensure that the update occurs only when the SOC calculation parameter is explicitly set to False.
It solves , #944