Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DOME 4.0 to the acknowledgement #943

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Nov 25, 2024

This PR

  • adds DOME 4.0 to the acknowledgement, both README and the docs page.
  • update the arrangement of the logos.
  • update the authors and app description.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.40%. Comparing base (363be6f) to head (533d514).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #943   +/-   ##
=======================================
  Coverage   68.40%   68.40%           
=======================================
  Files         110      110           
  Lines        6096     6096           
=======================================
  Hits         4170     4170           
  Misses       1926     1926           
Flag Coverage Δ
python-3.11 68.40% <ø> (+0.01%) ⬆️
python-3.9 68.41% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@superstar54
Copy link
Member Author

Hi @mikibonacci, @AndresOrtegaGuerrero, and @edan-bainglass, who has time to do a quick review on this PR? Thanks!

setup.cfg Outdated
@@ -66,7 +66,7 @@ aiida.workflows =

[aiidalab]
title = Quantum ESPRESSO
description = Perform Quantum ESPRESSO calculations
description = The Quantum ESPRESSO (QE) app is a web-based interface in AiiDAlab, enabling users to perform first-principles calculations and compute material properties (e.g., band structure) directly in their browser.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Quantum ESPRESSO (QE) app is a web-based interface within AiiDAlab that allows users to perform first-principles calculations and analyze material properties (e.g., band structures) directly from their browser.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I modified it as you suggested.

Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

@superstar54
Copy link
Member Author

@AndresOrtegaGuerrero Thanks for the quick review!

@superstar54 superstar54 merged commit 2fd8c91 into aiidalab:main Nov 25, 2024
8 checks passed
@superstar54 superstar54 deleted the add_demo_ack branch November 25, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants