Add layer of abstraction in Panel classes
#945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edan-bainglass
force-pushed
the
panel-refactor
branch
from
87b56b5 to
9d6839f
Compare
edan-bainglass
force-pushed
the
panel-refactor
branch
5 times, most recently
from
555701f to
1ae24a8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #945 +/- ##
=======================================
Coverage 67.85% 67.85%
=======================================
Files 110 110
Lines 6206 6206
=======================================
Hits 4211 4211
Misses 1995 1995
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
edan-bainglass
force-pushed
the
panel-refactor
branch
from
1ae24a8 to
81cb0e0
Compare
|
@superstar54 please have a look at this when you get a chance 🙏 |
edan-bainglass
force-pushed
the
panel-refactor
branch
from
81cb0e0 to
4ba319f
Compare
edan-bainglass
added a commit
that referenced
this pull request
Dec 9, 2024
This PR looks to clean up the recently implemented plugin-based tab system in the resources/submission step (#939). The idea is to leverage the newly developed abstraction in #945 to encapsulate the behavior of ANY resource settings panel, leaving the global resource settings panel to override based on its unique added features. A few added items addressed in this PR: - PW code parallelization widget syncing between tabs - Support for syncing newly setup codes - Warning notification for overridden plugin resources - Syncing back with global resources on un-override
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a layer of abstraction for settings panels though the new
ConfigurationSettingsPanelandResourceSettingsPanelclasses and their respectiveModelclasses. The rest of the codebase has been renamed for clarity.