-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run test publish workflow on push to release/ branches #594
Conversation
3ed9d88
to
b3df873
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #594 +/- ##
=======================================
Coverage 96.21% 96.21%
=======================================
Files 11 11
Lines 1188 1188
=======================================
Hits 1143 1143
Misses 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -24,6 +24,7 @@ repos: | |||
rev: 0.2.3 | |||
hooks: | |||
- id: yamlfmt | |||
args: [--preserve-quotes] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yakutovicha can you take a look? Note that the publish workflow as specified here was there basically as is before I made any changes, the idea that you can inspect a release by first releasing on TestPyPI, where you can then inspect the package. But practically this couldn't really be used with bumpver, since you'd always push to master. (not saying which is better, just providing context). |
Going to merge this, since we need to release a patch version. |
I noticed when releasing version 2.2.0 that the test publish workflow was not triggered on the PR in #593. This was my mistake: At some point I changed the triggering event from
push
topull_request
. However, thebranches
filter that we use so that the test-publish is only run on release branches, has a different semantic meaning forpull_request
event --- it specifies the target branch, not the branch that is being merged.