Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test publish workflow on push to release/ branches #594

Merged
merged 6 commits into from
May 4, 2024

Conversation

danielhollas
Copy link
Contributor

@danielhollas danielhollas commented Apr 30, 2024

I noticed when releasing version 2.2.0 that the test publish workflow was not triggered on the PR in #593. This was my mistake: At some point I changed the triggering event from push to pull_request. However, the branches filter that we use so that the test-publish is only run on release branches, has a different semantic meaning for pull_request event --- it specifies the target branch, not the branch that is being merged.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (1bba240) to head (3e60c9b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #594   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files          11       11           
  Lines        1188     1188           
=======================================
  Hits         1143     1143           
  Misses         45       45           
Flag Coverage Δ
python-3.10 96.21% <ø> (ø)
python-3.9 96.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -24,6 +24,7 @@ repos:
rev: 0.2.3
hooks:
- id: yamlfmt
args: [--preserve-quotes]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielhollas danielhollas marked this pull request as ready for review April 30, 2024 15:07
@danielhollas danielhollas changed the title Run test publish workflow on pull_request Run test publish workflow on push to release/ branches Apr 30, 2024
@danielhollas
Copy link
Contributor Author

@yakutovicha can you take a look?

Note that the publish workflow as specified here was there basically as is before I made any changes, the idea that you can inspect a release by first releasing on TestPyPI, where you can then inspect the package. But practically this couldn't really be used with bumpver, since you'd always push to master. (not saying which is better, just providing context).

@danielhollas
Copy link
Contributor Author

Going to merge this, since we need to release a patch version.

@danielhollas danielhollas merged commit 88a498a into master May 4, 2024
14 checks passed
@danielhollas danielhollas deleted the release/test branch May 4, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant