Accept an optional logging Output widget for logging monitor exceptions
#669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #669 +/- ##
==========================================
- Coverage 83.41% 83.35% -0.07%
==========================================
Files 17 17
Lines 3581 3586 +5
==========================================
+ Hits 2987 2989 +2
- Misses 594 597 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
edan-bainglass
added a commit
to aiidalab/aiidalab-qe
that referenced
this pull request
Feb 5, 2025
This PR adds a flag, which if True, adds an `Output` widget at the bottom of the app, accompanied by a reset button. The widget can then be passed down to any part of the app that needs to be tested. The PR hardcodes one use-case - monitoring. The `ProcessMonitor` was recently changed (aiidalab/aiidalab-widgets-base#669) to accept an output widget and use it to log exceptions in monitored callbacks. This PR passes the output widget (if included) down to the `ProcessMonitor` instance, exposing its exceptions. This is useful for debugging issues in the results step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.