CI: Pin Ubuntu version to fix Firefox installation #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump uv and aiida-core versions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
=======================================
Coverage 83.35% 83.35%
=======================================
Files 17 17
Lines 3586 3586
=======================================
Hits 2989 2989
Misses 597 597
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danielhollas
changed the title
edan-bainglass
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Thanks @danielhollas. Obviously didn't get a breather to test your suggestion, but sounds like it works. Thanks for the fix 🙏
danielhollas
added a commit
that referenced
this pull request
Feb 6, 2025
- Pin ubuntu version to 22.04 to fix Firefox installation - Pin all other ubuntu versions to 24.04 - Bump uv and aiida-core versions to latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinning the ubuntu version to 22.04 as the CI runner seems to fix the Firefox installation, see #672 for details. At some point we should probably bump the Firefox version that we use (and that would supposedly work with newer Ubuntu) but this is the fastest fix for now.
I also changed all the other
ubuntu-latesttoubuntu-24.04as a best practice to prevent this kind of issues in the future.Also bump uv and aiida-core versions to latest.