Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax wrapt requirement. #5607

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Jul 27, 2022

No description provided.

@csadorf
Copy link
Contributor Author

csadorf commented Jul 28, 2022

Looks like the current test failures are related to #5606 .

@csadorf csadorf added the pr/blocked PR is blocked by another PR that should be merged first label Jul 28, 2022
@csadorf csadorf force-pushed the deps/relax-wrapt-requirement branch from dac094c to a932f33 Compare August 4, 2022 08:26
@csadorf csadorf added dependencies Pull requests that update a dependency file and removed pr/blocked PR is blocked by another PR that should be merged first labels Aug 4, 2022
@sphuber
Copy link
Contributor

sphuber commented Aug 11, 2022

@csadorf Think you may have created this as a test, but it might still be good to merge anyway? I also don't see a reason to be so restrictive on wrapt. Tests should now run without problems

@csadorf csadorf marked this pull request as ready for review August 15, 2022 09:34
@csadorf csadorf requested a review from sphuber August 15, 2022 12:44
@sphuber sphuber merged commit 634d9a1 into aiidateam:main Aug 15, 2022
@sphuber sphuber deleted the deps/relax-wrapt-requirement branch August 15, 2022 12:46
@ml-evs
Copy link

ml-evs commented Oct 25, 2022

Hi @sphuber, didn't feel worth raising an issue on this (but happy to). The previous pinning of wrapt is the only blocker for supporting Python 3.11 that we are facing at optimade-python-tools (see Materials-Consortia/optimade-python-tools#1362). Is there a reason this commit wasn't included in the last aiida-core 2.0.4 release, or can we expect this to be sorted in the next release? Cheers

@sphuber
Copy link
Contributor

sphuber commented Oct 25, 2022

No particular reason not to include it, it just didn't feel critical, and we are currently in a branching strategy where current main is the upcoming 2.1 and so for patch releases, we had to make separate support branch with explicit cherry-picks, so only took the critical fixes. We are coming close to the v2.1 release though. There are only a few things remaining for the milestone all of which have open PRs. Hoping to release in the next week or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants