Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend fix: type call error for AiiDAConfigDir.set #6646

Merged

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Nov 29, 2024

One place not use the correct type cast for config path passing to AiiDAConfigDir.set after #6610

@unkcpz unkcpz requested a review from mbercx November 29, 2024 14:58
@unkcpz
Copy link
Member Author

unkcpz commented Nov 29, 2024

Thanks @mbercx! Here is a quick amend fix. I also did a search globally and this is the only place I didn't use the correct type casting for path string (hopefully).
I was trying to add a test for the fixture, but the code path where error raised is hard to mock (it require first the reset and then the config fixture yield failed), so I gave up.

@unkcpz
Copy link
Member Author

unkcpz commented Nov 29, 2024

I think this fixture is deprecated, it is better to use the one in aiida/tools/pytest_fixtures. But for not breaking also other plugins that use the old fixture, this fix is required.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.89%. Comparing base (ef60b66) to head (b27abf2).
Report is 151 commits behind head on main.

Files with missing lines Patch % Lines
src/aiida/manage/tests/pytest_fixtures.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6646      +/-   ##
==========================================
+ Coverage   77.51%   77.89%   +0.39%     
==========================================
  Files         560      567       +7     
  Lines       41444    42180     +736     
==========================================
+ Hits        32120    32853     +733     
- Misses       9324     9327       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unkcpz unkcpz merged commit dbdc36c into aiidateam:main Dec 2, 2024
9 of 10 checks passed
@unkcpz unkcpz deleted the Amend-fix-for-typing-error-from-AiiDAConfigDir branch December 2, 2024 10:34
@unkcpz
Copy link
Member Author

unkcpz commented Dec 2, 2024

I just merge this without approve since it is a fix for deprecated API and this should fix nightly test fail in aiida-quantumespresso.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant