Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: autorun uv lock if --check fails #6711

Closed
wants to merge 2 commits into from
Closed

pre-commit: autorun uv lock if --check fails #6711

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af8c2d3
pre-commit auto run uv lock
khsrali Jan 16, 2025
cc5221e
Merge branch 'main' into uv-update
khsrali Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,8 @@ repos:

- id: check-uv-lock
name: Check uv lockfile up to date
# NOTE: This will not automatically update the lockfile
entry: uv lock --check
entry: bash -c 'uv lock --check || uv lock'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure it this works correctly, because we need to fail the pre-commit check if the lockfile is updated, but based on my limited testing uv lock returns 0 regardless if the lockfile was updated or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess with --check return zero only if lockfile is already updated.
I ran a few manual tests, for me it works.

skip: false
language: system
pass_filenames: false
files: >-
Expand Down
Loading