Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First steps to make protocols scheduler agnostic #1011

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

First steps to make protocols scheduler agnostic #1011

wants to merge 3 commits into from

Commits on May 16, 2024

  1. First steps to make protocols scheduler agnostic. 

    The current protocols implicitly rely on the `Slurm` scheduler by specifying the number of machines
in `metadata.options.resources`. This can cause problems when using different schedulers
in combination with `get_builder_from_protocol`. Here, we add this information to the documentation
and add a warning that the options need to be explicitly specified in future versions.
    @t-reents
    t-reents committed May 16, 2024
    Configuration menu
    Copy the full SHA
    0566c7a View commit details
    Browse the repository at this point in the history

  2. Add warning to other workflows 

    In addition to the previous changes to the `pw` `WorkChain`s, this commit adds a warning to all the other `WorkChain`s that provide the `get_builder_from_protcol` method.
    @t-reents
    t-reents committed May 16, 2024
    Configuration menu
    Copy the full SHA
    a139465 View commit details
    Browse the repository at this point in the history

  3. Add documentation about get_builder_from_protocol 

    This commit adds some general remarks about the `get_builder_from_protocol` methods in the `How to - Workflows` section.
    @t-reents
    t-reents committed May 16, 2024
    Configuration menu
    Copy the full SHA
    300e4cc View commit details
    Browse the repository at this point in the history