Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AiiDAProcessTask #389

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Add AiiDAProcessTask #389

merged 4 commits into from
Dec 12, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Dec 12, 2024

This PR adds an AiiDAProcessTask, which can take an executor as input and thus create the input and output sockets based on the executor. However, I decided not to use it because it would not work if the user used it directly in the add_task method.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.63%. Comparing base (d7e5728) to head (633ee91).

Files with missing lines Patch % Lines
.../aiida_workgraph/utils/inspect_aiida_components.py 94.80% 4 Missing ⚠️
src/aiida_workgraph/utils/__init__.py 90.47% 2 Missing ⚠️
src/aiida_workgraph/decorator.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #389      +/-   ##
==========================================
+ Coverage   91.30%   91.63%   +0.33%     
==========================================
  Files          66       67       +1     
  Lines        4645     4712      +67     
==========================================
+ Hits         4241     4318      +77     
+ Misses        404      394      -10     
Flag Coverage Δ
python-3.11 91.59% <95.83%> (+0.33%) ⬆️
python-3.12 91.57% <95.83%> (+0.31%) ⬆️
python-3.9 91.61% <95.83%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 merged commit 575106e into main Dec 12, 2024
15 checks passed
@superstar54 superstar54 deleted the aiida_component_task branch December 12, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants