Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an exception explicitly when the timeout is exceeded #390

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Dec 13, 2024

To provide a better user experience, we raise an exception explicitly when the timeout is exceeded in the wait method.

… when the timeout is exceeded in the wait method.
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.68%. Comparing base (575106e) to head (936548d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
+ Coverage   91.61%   91.68%   +0.06%     
==========================================
  Files          67       67              
  Lines        4712     4739      +27     
==========================================
+ Hits         4317     4345      +28     
+ Misses        395      394       -1     
Flag Coverage Δ
python-3.11 91.64% <100.00%> (+0.06%) ⬆️
python-3.12 91.64% <100.00%> (+0.06%) ⬆️
python-3.9 91.68% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 merged commit ea54c16 into main Dec 13, 2024
13 of 15 checks passed
@superstar54 superstar54 deleted the raise_when_timeout branch December 13, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants