Fix PythonJob need aiida_workgraph on remote computer
#396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
==========================================
- Coverage 92.25% 92.23% -0.02%
==========================================
Files 67 67
Lines 4738 4741 +3
==========================================
+ Hits 4371 4373 +2
- Misses 367 368 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mikibonacci
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Hi @superstar54 , I tested it and it works, LGTM! Thanks a lot for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the decorated function of PythonJob, we attached the WorkGraph's
Taskclass to the function, this will be pickled together with the function, thus, when unpickling the function on the remote computer, it requireaiida-workgraph.Thsi PR deletes the workgraph related attributes of the decorated func if exist.