Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to setup-python@v5 #172

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

khsrali
Copy link
Contributor

@khsrali khsrali commented May 21, 2024

actions/setup-python@v2 is deprecated and currently is causing continuous integration test fail for macos.
This will fix for macos with python 3.9,3.10, and 3.11.
macos && python 3.8 is still failing for different reasons: that apparently cython dependency is not properly installed, which I don't understand why. But that is independent of this fix. (used to fail even with setup-python@v1)

@unkcpz
Copy link
Member

unkcpz commented Jul 19, 2024

actions/setup-python is now v5, please update it.

macos && python 3.8 is still failing for different reasons: that apparently cython dependency is not properly installed

It's better to fix it first.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some minor requests.

@khsrali
Copy link
Contributor Author

khsrali commented Jul 19, 2024

actions/setup-python is now v5, please update it.

now, all macos tests fails 😆

@khsrali
Copy link
Contributor Author

khsrali commented Jul 19, 2024

Will fix this on Monday

@khsrali
Copy link
Contributor Author

khsrali commented Jul 24, 2024

macos && python 3.8 is still failing for different reasons: that apparently cython dependency is not properly installed, which I don't understand why.

Alright, there was bug in dependency pyyaml==6.0 with python 3.8 and macos, which has been solved in their patch version pyyaml==6.0.1 conda-forge/pyyaml-feedstock#38

requirements.lock updated.

@khsrali khsrali changed the title Update to setup-python@v2 Update to setup-python@v5 Jul 24, 2024
@khsrali khsrali merged commit 02a43fe into aiidateam:main Jul 24, 2024
15 checks passed
@khsrali khsrali deleted the update-workflow branch July 24, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants