Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov updated token #176

Merged
merged 3 commits into from
Sep 20, 2024
Merged

codecov updated token #176

merged 3 commits into from
Sep 20, 2024

Conversation

khsrali
Copy link
Contributor

@khsrali khsrali commented Sep 19, 2024

No description provided.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (e469ef4) to head (a295c79).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          10       10           
  Lines        2086     2099   +13     
=======================================
+ Hits         2084     2097   +13     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khsrali khsrali requested a review from agoscinski September 19, 2024 08:43
@agoscinski
Copy link
Contributor

agoscinski commented Sep 19, 2024

I think we can increase non code coverage to 5%. This 1% is bit insane.

@agoscinski
Copy link
Contributor

Because of @giovannipizzi comments I would put it to 98.5% to not allow too much slack. But it is also not part of this PR to write the tests for earlier PRs.

@giovannipizzi
Copy link
Member

Ok

@khsrali khsrali merged commit 5601ee9 into aiidateam:main Sep 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants