Use Ruff for linting #289
Merged
Use Ruff for linting #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unkcpz
force-pushed
the
ruff
branch
5 times, most recently
from
32ecbe2
to
4150816
Compare
unkcpz
commented
Nov 27, 2024
Comment on lines
+596
to
+597
| # XXX: can return a reference and gracefully use task to cancel itself when the upper call stack fails | ||
| asyncio.ensure_future(proc.step_until_terminated()) # noqa: RUF006 |
There was a problem hiding this comment.
The linter complain is the reference to the coroutine is not returned. I think the standard way is to use the task to do graceful shutdown.
I'll further investigate on it, what I think is the returned reference to the task returned to the function where it is called (ProcessLauncher) and before this task get run it can be cancelled without other exception from the event loop.
There was a problem hiding this comment.
Let me know if you think it is better to not put dev notes in the src code. @agoscinski
4 tasks
unkcpz
force-pushed
the
ruff
branch
10 times, most recently
from
0bb21a8
to
d433143
Compare
|
I move the fix for passing 3.12 tests to #292 so this PR only contains the changes recommended from ruff. It is ready to be review. |
sphuber
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ruff pre-commit configs are mainly get from
aiida-core.For the linter complain in tests, I simply add
# noqato silent those.testfolder totests