Implemented detection of outdated or not #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aikar
requested changes
Apr 12, 2020
|
I have made the changes I think you asked for. If I missed something, I apologize. I noticed a flaw in the initial attempt where it would only set the latest stuff if they didn't have it cached. Now it's split up to
|
aikar
requested changes
May 23, 2020
- Got rid of the need to use dangerouslySetInnerHTML - Changed the labels to not use strings and to actually set the values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first time I've used React, I know this isn't clean.
If someone who is good in JS would like to clean it up / make some changes, I'd be more than grateful.