Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better types #930

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Better types #930

merged 2 commits into from
Nov 20, 2024

Conversation

asvetlov
Copy link
Member

The PR runs against the whole project instead of testing file-by-file.

Ideally, we should use strict = True config option but now it produces too much errors

@asvetlov asvetlov enabled auto-merge (squash) November 20, 2024 18:43
@asvetlov asvetlov merged commit 702003d into main Nov 20, 2024
11 checks passed
@asvetlov asvetlov deleted the strict-mypy branch November 20, 2024 18:48
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.66%. Comparing base (a40b374) to head (fd06ecf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
aiodocker/stream.py 57.14% 3 Missing ⚠️
aiodocker/logs.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
- Coverage   80.75%   80.66%   -0.09%     
==========================================
  Files          24       24              
  Lines        1434     1443       +9     
  Branches      206      206              
==========================================
+ Hits         1158     1164       +6     
- Misses        184      187       +3     
  Partials       92       92              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant