Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement scan for composite aggregation #225

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pgtuk
Copy link
Contributor

@pgtuk pgtuk commented Jul 15, 2020

What do these changes do?

Added convenient scan for composite aggregations as specified in es docs.

Are there changes in behavior for the user?

None.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@pgtuk pgtuk changed the title implement scan composite aggregation implement scan for composite aggregation Jul 15, 2020
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #225 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #225      +/-   ##
=========================================
- Coverage    0.23%   0.19%   -0.04%     
=========================================
  Files           6       6              
  Lines         434     520      +86     
  Branches       76      89      +13     
=========================================
  Hits            1       1              
- Misses        433     519      +86     
Impacted Files Coverage Δ
aioelasticsearch/helpers.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8498b5...05c358b. Read the comment docs.

@CLAassistant

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants