Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small speed up to StreamWriter.__init__ #10038

Merged
merged 5 commits into from
Nov 24, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 24, 2024

Use classvar defaults to avoid __init__ overhead. AbstractStreamWriter already does this so we can drop a few duplicates as well.

Screenshot 2024-11-24 at 4 58 02 PM

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (5f5729d) to head (e20a6c1).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10038      +/-   ##
==========================================
- Coverage   98.73%   98.73%   -0.01%     
==========================================
  Files         121      121              
  Lines       36769    36766       -3     
  Branches     4392     4392              
==========================================
- Hits        36304    36301       -3     
  Misses        314      314              
  Partials      151      151              
Flag Coverage Δ
CI-GHA 98.62% <100.00%> (-0.01%) ⬇️
OS-Linux 98.31% <100.00%> (-0.01%) ⬇️
OS-Windows 96.14% <100.00%> (-0.01%) ⬇️
OS-macOS 97.41% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.26% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.85% <100.00%> (-0.01%) ⬇️
Py-3.11.10 97.84% <100.00%> (-0.01%) ⬇️
Py-3.11.9 97.31% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 98.37% <100.00%> (-0.01%) ⬇️
Py-3.13.0 98.35% <100.00%> (-0.01%) ⬇️
Py-3.9.13 97.18% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.76% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 97.33% <100.00%> (-0.01%) ⬇️
VM-macos 97.41% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.31% <100.00%> (-0.01%) ⬇️
VM-windows 96.14% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Nov 24, 2024

CodSpeed Performance Report

Merging #10038 will not alter performance

Comparing speed_up_streamwriter_init (e20a6c1) with master (5f5729d)

Summary

✅ 44 untouched benchmarks

@bdraco bdraco changed the title DNM: Small speed up to StreamWriter.__init__ Small speed up to StreamWriter.__init__ Nov 24, 2024
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Nov 24, 2024
@bdraco bdraco marked this pull request as ready for review November 24, 2024 23:42
aiohttp/http_writer.py Outdated Show resolved Hide resolved
@bdraco bdraco merged commit 6f4e961 into master Nov 24, 2024
40 checks passed
@bdraco bdraco deleted the speed_up_streamwriter_init branch November 24, 2024 23:58
Copy link
Contributor

patchback bot commented Nov 24, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/6f4e9615d74c7d4935c11a2c9497cf6aae7149f3/pr-10038

Backported as #10039

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 24, 2024
Copy link
Contributor

patchback bot commented Nov 24, 2024

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/6f4e9615d74c7d4935c11a2c9497cf6aae7149f3/pr-10038

Backported as #10040

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 24, 2024
bdraco added a commit that referenced this pull request Nov 25, 2024
bdraco added a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant