-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small speed up to StreamWriter.__init__
#10038
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10038 +/- ##
==========================================
- Coverage 98.73% 98.73% -0.01%
==========================================
Files 121 121
Lines 36769 36766 -3
Branches 4392 4392
==========================================
- Hits 36304 36301 -3
Misses 314 314
Partials 151 151
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10038 will not alter performanceComparing Summary
|
StreamWriter.__init__
StreamWriter.__init__
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #10039 🤖 @patchback |
(cherry picked from commit 6f4e961)
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10040 🤖 @patchback |
(cherry picked from commit 6f4e961)
…_init__` (#10040) Co-authored-by: J. Nick Koston <[email protected]>
…_init__` (#10039) Co-authored-by: J. Nick Koston <[email protected]>
Use classvar defaults to avoid
__init__
overhead.AbstractStreamWriter
already does this so we can drop a few duplicates as well.