-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example projects page #3367
Conversation
docs/examples.rst
Outdated
- `polls <https://github.com/aio-libs/aiohttp-demos/tree/master/demos/chat>`_ | ||
Simple *polls* application with PostgreSQL storage. | ||
|
||
- `Blog <https://github.com/aio-libs/aiohttp-demos/tree/master/demos/chat>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This thing is titlecased, which others ain't. Maybe it's worth keeping the same style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
.. _aiohttp-examples: | ||
|
||
================ | ||
Example Projects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Demo projects maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
Codecov Report
@@ Coverage Diff @@
## master #3367 +/- ##
==========================================
- Coverage 97.93% 97.93% -0.01%
==========================================
Files 44 44
Lines 8482 8517 +35
Branches 1378 1394 +16
==========================================
+ Hits 8307 8341 +34
Misses 75 75
- Partials 100 101 +1
Continue to review full report at Codecov.
|
I think better to keep the list in aiohttp-demos documentation and add a link to demos page into aiohttp docs. |
Ok, not sure about the place where to put it, we already have a link in README. |
.. _aiohttp-examples: | ||
|
||
================ | ||
Example Projects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
- `chat <https://github.com/aio-libs/aiohttp-demos/tree/master/demos/chat>`_ | ||
Simple chat using websockets. | ||
|
||
- `polls <https://github.com/aio-libs/aiohttp-demos/tree/master/demos/chat>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace link to https://github.com/aio-libs/aiohttp-demos/tree/master/demos/polls
- `polls <https://github.com/aio-libs/aiohttp-demos/tree/master/demos/chat>`_ | ||
Simple *polls* application with PostgreSQL storage. | ||
|
||
- `blog <https://github.com/aio-libs/aiohttp-demos/tree/master/demos/chat>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/aio-libs/aiohttp-demos/tree/master/demos/blog
What's about https://demos.aiohttp.org/en/latest/ ? |
@asvetlov 10 min 😀 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
What do these changes do?
As discussed in aio-libs/aiohttp-demos#32 I am adding page with list of example projects to Misc subsection.
Are there changes in behavior for the user?
Related issue number
aio-libs/aiohttp-demos#32
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.