Reduce code indent in ResponseHandler.data_received

[bdraco]

What do these changes do?

Code cleanup only, no functional change

There were some else after returns that could be converted to guards to reduce code indent.

While looking at the full WebSockets path for #8258 I noticed this could be improved a bit

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 98.67%. Comparing base (afb5ebb) to head (896a2f8).
Report is 293 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
aiohttp/client_proto.py	83.33%	2 Missing and 3 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #8699   +/-   ##
=======================================
  Coverage   98.66%   98.67%           
=======================================
  Files         116      116           
  Lines       35638    35639    +1     
  Branches     4225     4225           
=======================================
+ Hits        35164    35165    +1     
  Misses        319      319           
  Partials      155      155           

Flag	Coverage Δ
CI-GHA	98.55% <83.33%> (+<0.01%)	⬆️
OS-Linux	98.23% <83.33%> (+<0.01%)	⬆️
OS-Windows	96.11% <76.66%> (+<0.01%)	⬆️
OS-macOS	97.43% <83.33%> (+<0.01%)	⬆️
Py-3.10.11	97.28% <83.33%> (+1.60%)	⬆️
Py-3.10.15	97.71% <83.33%> (+<0.01%)	⬆️
Py-3.11.10	97.77% <83.33%> (+<0.01%)	⬆️
Py-3.11.9	97.35% <83.33%> (+<0.01%)	⬆️
Py-3.12.7	98.25% <83.33%> (+<0.01%)	⬆️
Py-3.13.0	98.24% <83.33%> (+<0.01%)	⬆️
Py-3.9.13	97.20% <83.33%> (-0.01%)	⬇️
Py-3.9.20	97.62% <83.33%> (+<0.01%)	⬆️
Py-pypy7.3.16	97.24% <83.33%> (+<0.01%)	⬆️
VM-macos	97.43% <83.33%> (+<0.01%)	⬆️
VM-ubuntu	98.23% <83.33%> (+<0.01%)	⬆️
VM-windows	96.11% <76.66%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bdraco]

Looks like we are missing coverage for tail

[Dreamsorcerer]

I feel like that relates to #8597 (comment) or one of my other parser changes. I'm not really sure if it's still possible to reach that code at all...

[bdraco]

I'll dig through the code paths this weekend if flights cooperate.

[bdraco]

Looks like websocket will never have a tail unless there is an exception

[bdraco]

I spent a few hours digging at it, and I can't find a case or make a case where tail exists and upgraded is False

[Dreamsorcerer]

Then I reckon remove it, but also skip the 3.10 backport as a precaution.

[bdraco]

Still having trouble getting comfortable with removing that code, need to spend a few more hours tracing

[bdraco]

I wonder if it is possible and we don't have coverage for it.

We didn't have test coverage for split WebSocket payloads until #9649

[codspeed-hq]

CodSpeed Performance Report

Merging #8699 will not alter performance

_{Comparing else_after_return (896a2f8) with master (afb5ebb)}

Summary

✅ 13 untouched benchmarks