Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: Benchmark overhead of setdefault calls in _prepare_headers #9898

Closed
wants to merge 1 commit into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 15, 2024

Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #9898 will not alter performance

Comparing prepare_headers_setdefault (a1cfe90) with master (5ab2d47)

Summary

✅ 25 untouched benchmarks

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.71%. Comparing base (5ab2d47) to head (a1cfe90).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
aiohttp/web_response.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9898      +/-   ##
==========================================
- Coverage   98.71%   98.71%   -0.01%     
==========================================
  Files         119      119              
  Lines       36371    36373       +2     
  Branches     4320     4322       +2     
==========================================
+ Hits        35903    35904       +1     
  Misses        315      315              
- Partials      153      154       +1     
Flag Coverage Δ
CI-GHA 98.60% <83.33%> (-0.01%) ⬇️
OS-Linux 98.28% <83.33%> (-0.01%) ⬇️
OS-Windows 96.09% <83.33%> (-0.01%) ⬇️
OS-macOS 97.36% <83.33%> (-0.01%) ⬇️
Py-3.10.11 97.22% <83.33%> (-0.01%) ⬇️
Py-3.10.15 97.82% <83.33%> (-0.01%) ⬇️
Py-3.11.10 97.81% <83.33%> (-0.01%) ⬇️
Py-3.11.9 97.26% <83.33%> (-0.01%) ⬇️
Py-3.12.7 98.35% <83.33%> (+<0.01%) ⬆️
Py-3.13.0 98.34% <83.33%> (+<0.01%) ⬆️
Py-3.9.13 97.14% <83.33%> (+<0.01%) ⬆️
Py-3.9.20 97.69% <83.33%> (-0.05%) ⬇️
Py-pypy7.3.16 97.30% <83.33%> (-0.01%) ⬇️
VM-macos 97.36% <83.33%> (-0.01%) ⬇️
VM-ubuntu 98.28% <83.33%> (-0.01%) ⬇️
VM-windows 96.09% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member Author

bdraco commented Nov 15, 2024

no difference

@bdraco bdraco closed this Nov 15, 2024
@bdraco bdraco deleted the prepare_headers_setdefault branch November 15, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant