Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9900/7180ea8e backport][3.10] Add benchmark for a route that supports multiple methods #9901

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 15, 2024

This is a backport of PR #9900 as merged into master (7180ea8).

To get a better idea how much of a speed up #9899 will be

@bdraco bdraco enabled auto-merge (squash) November 15, 2024 06:22
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #9901 will not alter performance

Comparing patchback/backports/3.10/7180ea8e7dfa1c026c7778e2c665752e6e8f6d8b/pr-9900 (fe407ed) with 3.10 (e5917cd)

Summary

✅ 24 untouched benchmarks

🆕 2 new benchmarks

Benchmarks breakdown

Benchmark 3.10 patchback/backports/3.10/7180ea8e7dfa1c026c7778e2c665752e6e8f6d8b/pr-9900 Change
🆕 test_one_hundred_simple_get_requests_multiple_methods_route[pyloop] N/A 41.7 ms N/A
🆕 test_ten_web_middlewares[pyloop] N/A 44.2 ms N/A

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.92%. Comparing base (361db7c) to head (fe407ed).
Report is 120 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #9901      +/-   ##
==========================================
+ Coverage   97.78%   97.92%   +0.13%     
==========================================
  Files         108      114       +6     
  Lines       34840    35911    +1071     
  Branches     4164     4327     +163     
==========================================
+ Hits        34070    35166    +1096     
+ Misses        573      553      -20     
+ Partials      197      192       -5     
Flag Coverage Δ
CI-GHA 97.81% <100.00%> (+0.13%) ⬆️
OS-Linux 97.51% <100.00%> (+0.14%) ⬆️
OS-Windows 95.12% <100.00%> (+0.16%) ⬆️
OS-macOS 97.21% <100.00%> (+0.15%) ⬆️
Py-3.10.11 97.07% <100.00%> (+0.02%) ⬆️
Py-3.10.15 97.01% <100.00%> (+0.03%) ⬆️
Py-3.11.10 97.14% <100.00%> (+0.19%) ⬆️
Py-3.11.9 97.15% <100.00%> (+0.12%) ⬆️
Py-3.12.6 ?
Py-3.12.7 97.59% <100.00%> (?)
Py-3.13.0 97.57% <100.00%> (?)
Py-3.8.10 94.52% <100.00%> (+0.03%) ⬆️
Py-3.8.18 96.86% <100.00%> (+0.08%) ⬆️
Py-3.9.13 96.99% <100.00%> (+0.03%) ⬆️
Py-3.9.20 96.93% <100.00%> (+0.03%) ⬆️
Py-pypy7.3.16 96.53% <100.00%> (+0.03%) ⬆️
VM-macos 97.21% <100.00%> (+0.15%) ⬆️
VM-ubuntu 97.51% <100.00%> (+0.14%) ⬆️
VM-windows 95.12% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit d4acbd6 into 3.10 Nov 15, 2024
37 of 38 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/7180ea8e7dfa1c026c7778e2c665752e6e8f6d8b/pr-9900 branch November 15, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant