Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9911/4441d3c8 backport][3.12] Only construct the allowed_methods set once for a StaticResource #9913

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 15, 2024

This is a backport of PR #9911 as merged into master (4441d3c).

noticed in #9899 (comment)

Likely to have minimal performance improvement besides saving some memory churn so I didn't call it in out the changelog

@bdraco bdraco enabled auto-merge (squash) November 15, 2024 15:58
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #9913 will not alter performance

Comparing patchback/backports/3.12/4441d3c84b7cc03e1ab566faf8b6c9de4fa3c0ff/pr-9911 (a4ce831) with 3.12 (4838f40)

Summary

✅ 26 untouched benchmarks

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (4838f40) to head (a4ce831).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12    #9913   +/-   ##
=======================================
  Coverage   98.00%   98.00%           
=======================================
  Files         120      120           
  Lines       36474    36475    +1     
  Branches     4370     4370           
=======================================
+ Hits        35745    35746    +1     
  Misses        545      545           
  Partials      184      184           
Flag Coverage Δ
CI-GHA 97.89% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.59% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.45% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.69% <100.00%> (-0.01%) ⬇️
Py-3.10.11 96.54% <100.00%> (-0.01%) ⬇️
Py-3.10.15 97.09% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.16% <100.00%> (-0.05%) ⬇️
Py-3.11.9 96.62% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 97.65% <100.00%> (-0.01%) ⬇️
Py-3.13.0 97.65% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.47% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.06% <100.00%> (+0.03%) ⬆️
Py-pypy7.3.16 96.62% <100.00%> (+<0.01%) ⬆️
VM-macos 96.69% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.59% <100.00%> (+<0.01%) ⬆️
VM-windows 94.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit dcc79e8 into 3.12 Nov 15, 2024
34 of 35 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/4441d3c84b7cc03e1ab566faf8b6c9de4fa3c0ff/pr-9911 branch November 15, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant