Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
First off - thanks for all the work on this package :)
This PR introduces a framework for auth plugins. This will make it easier to add auth plugins.
Why?
I need to implement the kerberos plugin. We also use this client with services that only imitate the mysql server (i.e. starrocks and proprietary services based on mysql-mimic), and I might need proprietary auth plugins.
Are there changes in behavior for the user?
Nope. All the existing auth_plugins should work as-is.
Related issue number
n/a
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.
This has tests in the sense that existing tests don't fail. But I don't think the existing tests for auth are that extensive, so it might warrant some more testing.
As for documentation - I'm not sure this should be documented just yet.