Remove keys from cache on exception #595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Remove key from cache as soon as the task fails.
Currently, it removes the key from the cache on subsequent retrival.
Benefits:
Are there changes in behavior for the user?
No (only noticable change should be less data in cache stats
cache_info()
)Related issue number
This PR can replace 595 one as there will be no more exeptions in cache stored.
This one introduces a bit more changes so if it is going in the wrong direction other one can be merged instead to remove memory leak only.
Checklist