Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine nested if statements in quoting_py #1206

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Combine nested if statements in quoting_py #1206

merged 1 commit into from
Oct 12, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 11, 2024

SSIA

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 11, 2024
@bdraco bdraco enabled auto-merge (squash) October 11, 2024 23:50
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (6edc731) to head (61e34e7).
Report is 224 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1206      +/-   ##
==========================================
- Coverage   95.57%   95.57%   -0.01%     
==========================================
  Files          25       25              
  Lines        4862     4861       -1     
  Branches      258      257       -1     
==========================================
- Hits         4647     4646       -1     
  Misses        189      189              
  Partials       26       26              
Flag Coverage Δ
CI-GHA 95.55% <100.00%> (-0.01%) ⬇️
MyPy 42.37% <100.00%> (-0.02%) ⬇️
OS-Linux 99.33% <100.00%> (-0.01%) ⬇️
OS-Windows 99.39% <100.00%> (-0.01%) ⬇️
OS-macOS 99.02% <100.00%> (-0.01%) ⬇️
Py-3.10.11 98.91% <100.00%> (-0.01%) ⬇️
Py-3.10.15 99.20% <100.00%> (-0.01%) ⬇️
Py-3.11.10 99.20% <100.00%> (-0.01%) ⬇️
Py-3.11.9 98.91% <100.00%> (-0.01%) ⬇️
Py-3.12.7 99.20% <100.00%> (-0.01%) ⬇️
Py-3.13.0 99.20% <100.00%> (-0.01%) ⬇️
Py-3.8.10 98.86% <100.00%> (-0.01%) ⬇️
Py-3.8.18 99.15% <100.00%> (-0.01%) ⬇️
Py-3.9.13 98.86% <100.00%> (-0.01%) ⬇️
Py-3.9.20 99.15% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.11 99.20% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 99.20% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.17 99.23% <100.00%> (-0.01%) ⬇️
VM-macos-latest 99.02% <100.00%> (-0.01%) ⬇️
VM-ubuntu-latest 99.33% <100.00%> (-0.01%) ⬇️
VM-windows-latest 99.39% <100.00%> (-0.01%) ⬇️
pytest 99.33% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 784452b into master Oct 12, 2024
45 of 47 checks passed
@bdraco bdraco deleted the quoting_nested branch October 12, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant