Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code made compatible with Airbnb style guide #2806

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

0o001
Copy link
Contributor

@0o001 0o001 commented Aug 7, 2023

Add arrays bracket newline
https://github.com/airbnb/javascript#arrays--bracket-newline

Add array destructuring
https://github.com/airbnb/javascript#destructuring--array

And severities array put inside the getSeverity function

Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is enforcing this change?

packages/eslint-config-airbnb-base/whitespace.js Outdated Show resolved Hide resolved
packages/eslint-config-airbnb/whitespace-async.js Outdated Show resolved Hide resolved
@0o001
Copy link
Contributor Author

0o001 commented Aug 7, 2023

What is enforcing this change?

I wanted to align the used codes with the format recommended in Airbnb's own style guide.

@ljharb
Copy link
Collaborator

ljharb commented Aug 7, 2023

Right, but our own eslint rules in this project should be enforcing that, rather than doing it manually.

@ljharb ljharb marked this pull request as draft August 15, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants