Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blurry CVImageElement drawing on high dpi (>1.0) displays #2896

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

richardhenry
Copy link

The canvas renderer CVImageElement draws blurry images on high dpi displays, like this example where the dpi is 2.0:

Screenshot 2022-12-21 at 6 41 08 PM

This diff changes the implementation so that images draw correctly:

Screenshot 2022-12-21 at 6 43 27 PM

I'm not sure if this is the optimal fix, but it seems to work.

@bodymovin
Copy link
Collaborator

hey thanks for the PR! If I understand it correctly, you're drawing the img directly to the canvas and dropping the buffer canvas, is that right?
(btw, can you update the PR without building the files?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants