Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cpu_rec.py (#13): make check on line 534 an equality check
Python 3.8 prints a syntax warning when an identity check is used with a literal. Using identity comparisons can lead to unexpected behavior. See: https://adamj.eu/tech/2020/01/21/why-does-python-3-8-syntaxwarning-for-is-literal/
- Loading branch information
c590566
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I also had to perform the same fix to use PyPy. Mainline should now work fine with PyPy for a big speed improvement. Thanks!
c590566
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is interesting that you mention that cpu_rec is much faster with PyPy. I will investigate this to see if it leads to ideas on how to improve its performance with CPython.