Fix autodoc #456
Merged
Fix autodoc #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new solver characteristic Maskable has a (hidden) attribute initialized to None. Thus the method `get_ref()` does not work on it, and updating the types_dict for the code generator was failing. As this attribute is not used in type annotations of methods (which was the purpose of types_dict) this is not a real issue. So we merely skip adding a type to it when member["ref"] does not exist.
fteicht
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new solver characteristic
Maskablehas a (hidden) attribute initialized to None. Thus the methodget_ref()does not work on it, and updating the types_dict for the code generator was failing. As this attribute is not used in type annotations of methods (which was the purpose oftypes_dict) this is not a real issue. So we merely skip adding a type to it when member["ref"] does not exist.