-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sources/base.py
documentation to properly reflect allowed write_strategy
arguments
#581
base: main
Are you sure you want to change the base?
Conversation
Fixes `Source.read()`'s documentation to correctly specify the allowed arguments for the `write_strategy` parameter
write_strategy
argumentssources/base.py
to reflect allowed write_strategy
arguments
sources/base.py
to reflect allowed write_strategy
argumentssources/base.py
documentation to properly reflect allowed write_strategy
arguments
sources/base.py
documentation to properly reflect allowed write_strategy
argumentssources/base.py
documentation to properly reflect allowed write_strategy
arguments
📝 WalkthroughWalkthroughThe pull request introduces a documentation update for the Changes
The change appears to be a documentation refinement, synchronizing the method's description with its actual implementation. The valid write strategy options are now explicitly listed as "append", "merge", "replace", or "auto". Would you like me to elaborate on any aspect of this change? Wdyt? 🤔 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (1)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This PR fixes
Source.read()
's documentation to correctly specify the allowed arguments for itswrite_strategy
parameter (merge
instead ofupsert
which is not a validWriteStragegy
enum value)Summary by CodeRabbit
read
method to clarify validwrite_strategy
options