Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update values keys in integrations/secrets #48569

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

vpipkt
Copy link
Contributor

@vpipkt vpipkt commented Nov 20, 2024

What

Fix documentation about using Azure KeyVault for secret manager

How

reference the key in the latest helm charts (e.g. workload-launcher), tried in my own helm release

Review guide

User Impact

Quicker onboarding of Azure KeyVault for secrets management

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Nov 20, 2024

@vpipkt is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024

CLA assistant check
All committers have signed the CLA.

@marcosmarxm
Copy link
Member

@vpipkt can you sign the CLA?

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @vpipkt

@vpipkt
Copy link
Contributor Author

vpipkt commented Nov 27, 2024

@marcosmarxm will look into CLA now... happy to do so

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 8:11am

@vpipkt vpipkt temporarily deployed to community-ci-auto December 5, 2024 08:05 — with GitHub Actions Inactive
@vpipkt vpipkt temporarily deployed to community-ci-auto December 5, 2024 08:05 — with GitHub Actions Inactive
@marcosmarxm marcosmarxm enabled auto-merge (squash) December 5, 2024 17:46
@marcosmarxm marcosmarxm merged commit 9708f98 into airbytehq:master Dec 5, 2024
28 checks passed
@vpipkt vpipkt deleted the patch-2 branch December 10, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation community
Projects
Development

Successfully merging this pull request may close these issues.

4 participants