Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for sahi>=0.11 #1156

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Conversation

fcakyon
Copy link
Contributor

@fcakyon fcakyon commented Nov 13, 2022

Hello @lgvaz, I am the core maintainer of sahi!

This PR upgrades to the new sahi api introduced in v0.11.0.

I also pinned the minimum sahi version to 0.11.1 since there have been many bug fixes and performance improvements since 0.8.*

@fcakyon fcakyon changed the title add support for sahi>0.11 add support for sahi>=0.11 Nov 13, 2022
@AlexandreBrown
Copy link
Contributor

AlexandreBrown commented Nov 23, 2022

@ai-fast-track FYI this would help our team since currently our CI fails because we use IceVision and this issue makes IceVision import fail which this PR aims to solve.

@ai-fast-track ai-fast-track merged commit 27ef883 into airctic:master Nov 23, 2022
@fcakyon fcakyon deleted the support-latest-sahi branch November 23, 2022 18:10
dnth added a commit to dnth/icevision that referenced this pull request Mar 6, 2024
* install torchtext==0.11.0 (airctic#1119)

* install icevision from master (as default) (airctic#1121)

* Feature/1124 Added Pytorch Lightning Test support for all models (airctic#1125)

* feature/1124 Added Pytorch Lightning Test support for mmdet

* feature/1124 Added Pytorch Lightning Test support for efficientdet

* feature/1124 Added Pytorch Lightning Test support for torchvision

* feature/1124 Added Pytorch Lightning Test support for yolov5

* feature/1124 Renamed shared evaluation method for mmdet

* feature/1124 Renamed shared evaluation method for efficientdet

* feature/1124 Renamed shared evaluation method for torchvision

* feature/1124 Renamed shared evaluation method for yolov5

* feature/1124 Added test for PL test step of efficientdet

* feature/1124 Added test for PL test step of mmdet

* feature/1124 Added test for PL test step of torchvision models

* feature/1124 Added test for PL test step of yolov5

* feature/1124 Updated object detection getting started guide to add PL test

* feature/1124 Updated environment.yml to fix icevision version not found

* feature/1124 Added unit tests for efficientdet lightning model adapter

* feature/1124 Added unit tests for mmdet lightning model adapter

* feature/1124 Added unit tests for torchvision lightning model adapter

* feature/1124 Added unit tests for yolov5 lightning model adapter

* feature/1124 Added unit tests for fastai unet lightning model adapter

* feature/1124 Fixed memory consumption in PL tests

* doc/1116 Added direction on how to import IceVision without wildcard import (airctic#1127)

* Update tests to use newer pytorch lightning (airctic#1133)

* force install pl>=1.7.0

* replace deprecated arguments

* bump minimal pl version from 1.4.6 to 1.5.0

* Export preds to coco annotations (airctic#1132)

* Add a function to export preds to COCO annotations

* Downsample example images to save space; add optional metadata parameter

* Separate 'info' field from the rest of 'addl_info' as a parameter

* Fix unsightly notebook outputs

* Fix slightly errant docstring. TODO: Add type hints

* Black formatting

* Clean up cluttered inference notebook output (airctic#1137)

Co-authored-by: Ubuntu <[email protected]>

* Make COCO exports remember original img resolutions (airctic#1142)

* Make COCO exports remember original img resolutions

* black formatting

* updates sahi dependency

* add support for sahi>=0.11 (airctic#1156)

* add support for sahi>0.11

* pin sahi version

* Added support for 3 bands float32 tiff images (airctic#1138)

* Added support for 3 bands float32 tiff images

* Removed circular dependency
- Bug introduced by airctic#1132
- Credits goes to https://github.com/FraPochetti for finding the issue

* Unit tests micro refactor

---------

Co-authored-by: AI Fast Track <[email protected]>
Co-authored-by: Alexandre Brown <[email protected]>
Co-authored-by: Paweł Potrykus <[email protected]>
Co-authored-by: Robert Boscacci <[email protected]>
Co-authored-by: Ubuntu <[email protected]>
Co-authored-by: Lucas Vazquez <[email protected]>
Co-authored-by: fatih <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants