Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asv publish skips results for non-existing commits #1410

Open
ev-br opened this issue Jun 21, 2024 · 0 comments
Open

asv publish skips results for non-existing commits #1410

ev-br opened this issue Jun 21, 2024 · 0 comments

Comments

@ev-br
Copy link

ev-br commented Jun 21, 2024

When .asv/results contains a #hash-virtualenv-py3.12.json results file but the commit hash is not present in the benchmarking branch (eg was rebased out), asv publish silently skips this result.
It might be better to still display it even if clicking on the commit in the web view produces 404 link.

My use case is running benchmarks on a cron. So I thought I'd just point asv to a branch, clone main to this branch and push an empty commit. This is not very hard to work around now that I know that asv expects a commit to be present :-). However it would be a little less mysterious if there was always a point on a graph from asv publish for every json result in .asv/results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant