-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: flink commands ignore the current project #391
client: flink commands ignore the current project #391
Conversation
Customers are used to set environment so they don't have to pass all arguments for each aiven-client command they run. This PR takes the current project into account in flink commands. [PM-4549]
Set current project
Before
After
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the current changes, it looks fine, and we can merge it.
However, I realized that the method get_project
doesn't consider the AIVEN_PROJECT
environment variable when inferring the project name where the default value of args.project
was the environment variable.
IMO, we should fix the get_project
to reflect the correct hierarchy of inference which should be argument -> environment -> config.
Additionally, we should fix the args.project default to behave similarly so as not to mislead developers in the future.
@dogukancagatay Do we agree that this should be a separate ticket? Thanks |
Customers are used to set environment so they don't have to pass all arguments for each aiven-client command they run. This PR takes the current project into account in flink commands.
PM-4549