Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API connector to model server #202

Merged
merged 197 commits into from
Nov 14, 2023

Conversation

imda-amdlahir
Copy link
Contributor

@imda-amdlahir imda-amdlahir commented Oct 24, 2023

Description

Merging API Connector implementation

Motivation and Context

Code changes is for the API Connector feature which enables user to test API model which is hosted on a remote server

Type of Change

  • feat: A new feature

How to Test

Checklist

Please check all the boxes that apply to this pull request using "x":

  • [x ] I have tested the changes locally and verified that they work as expected.
  • I have added or updated the necessary documentation (README, API docs, etc.).
  • [x ] I have added appropriate unit tests or functional tests for the changes made.
  • [x ] I have followed the project's coding conventions and style guidelines.
  • [x ] I have rebased my branch onto the latest commit of the main branch.
  • [x ] I have squashed or reorganized my commits into logical units.
  • [x ] I have added any necessary dependencies or packages to the project's build configuration.
  • [x ] I have performed a self-review of my own code.
  • I have read, understood and agree to the Developer Certificate of Origin below, which this project utilises.

Screenshots (if applicable)

[If the changes involve visual modifications, include screenshots or GIFs that demonstrate the changes.]

Additional Notes

[Add any additional information or context that might be relevant to reviewers.]

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
   have the right to submit it under the open source license
   indicated in the file; or

(b) The contribution is based upon previous work that, to the best
   of my knowledge, is covered under an appropriate open source
   license and I have the right under that license to submit that
   work with modifications, whether created in whole or in part
   by me, under the same open source license (unless I am
   permitted to submit under a different license), as indicated
   in the file; or

(c) The contribution was provided directly to me by some other
   person who certified (a), (b) or (c) and I have not modified
   it.

(d) I understand and agree that this project and the contribution
   are public and that a record of the contribution (including all
   personal information I submit with it, including my sign-off) is
   maintained indefinitely and may be redistributed consistent with
   this project or the open source license(s) involved.

imda-peckyoke and others added 30 commits June 27, 2023 10:57
…complex serialization for parameters and request body
…ub.com:IMDA-BTG/aiverify into feature/issue-41/api-connector-to-model-server
@kimeetok kimeetok self-requested a review October 26, 2023 06:22
Copy link
Contributor

@imda-benedictlee imda-benedictlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@imda-benedictlee imda-benedictlee requested review from miyamaya9 and removed request for kimeetok November 14, 2023 09:31
@miyamaya9 miyamaya9 merged commit cea3ac3 into main Nov 14, 2023
3 of 14 checks passed
@imda-benedictlee
Copy link
Contributor

imda-benedictlee commented Nov 15, 2023

All Test Cases in Docker Passed:

Smoke Test, Supported Models Test & API Connector Test
image

Edit: Currently facing issues with Invalid URL. Attached logs below.
Uploading test-engine-logs error for invalid url.txt…

@imda-benedictlee
Copy link
Contributor

imda-benedictlee commented Nov 17, 2023

Add Test Results for Docker. Attached is HTML Report of Test Results
Playwright Test Report For Docker.zip

@imda-benedictlee
Copy link
Contributor

Add Test Results in for Dev Script. Attached is HTML Report of Test Results
Playwright Test Report For Dev.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build API Connector to Remote Model Server
7 participants