-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce separate clikt-core
module that has no dependencies
#516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the code into two modules:
clikt-core
which contains most of the code and has zero dependencies, andclikt-mordant
which depends on mordant andclikt-core
and contains only the code that requires mordant.The command type heirarcy is now
BaseCliktCommand
(norun
function or mordant) ->CoreCliktCommand
(no mordant) ->CliktCommand
(all features).Some new
Context
configuration porperties likeexitProcess
were added to allow plugging in mordant, and custom command types can callContext.installMordant()
to set them all up at once.Fortunately, the
MordantHelpFormatter
was already pretty customizable, so I was able to extract most of it to a base class and create a newPlaintextHelpFormatter
without much extra code.The maven coordinates for
clikt-mordant
are stillcom.github.ajalt.clikt:clikt
, so the default feature set doesn't change.Fixes #507
Fixes #454