Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #5720

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Cleanup #5720

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,5 @@ demo/
api/
**/* *
**/node_modules
0*
0*
esm-resolver.js
102 changes: 51 additions & 51 deletions .github/ISSUE_TEMPLATE/add-to-website.yml
Original file line number Diff line number Diff line change
@@ -1,51 +1,51 @@
---
name: "🌐 Add a project to the list of project using Ace on its website."
description: Add a project to the list of projects using Ace, displayed on the website.
title: "Add project (project name) to the list of projects using Ace on its website"
labels: [website, needs-triage]
assignees: []
body:
- type: markdown
attributes:
value: |
The fastest way to get your project to be displayed on the website is to create a PR.
Examples: https://github.com/ajaxorg/ace/pull/5014, https://github.com/ajaxorg/ace/pull/5222.
If for any reason creating a PR is not an option for you, please proceed with filling out this issue. Thanks!
- type: input
id: name
attributes:
label: Project name
description: A name of the project to be used on Ace website.
validations:
required: true
- type: input
id: project-link
attributes:
label: Project link
description: A link to the project's website.
validations:
required: true
- type: input
id: logo-link
attributes:
label: Logo link
description: |
A link to the logo image to be used on the website for the project. If not provided, only the name of the project will be displayed.
By submitting this link, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
validations:
required: false
- type: textarea
id: info
attributes:
label: Additional information
description: Any additional information you would like to share.
validations:
required: false
- type: checkboxes
id: ack
attributes:
label: Acknowledgements
options:
- label: I may be able to implement this request.
required: false
---
name: "🌐 Add a project to the list of project using Ace on its website."
description: Add a project to the list of projects using Ace, displayed on the website.
title: "Add project (project name) to the list of projects using Ace on its website"
labels: [website, needs-triage]
assignees: []
body:
- type: markdown
attributes:
value: |
The fastest way to get your project to be displayed on the website is to create a PR.
Examples: https://github.com/ajaxorg/ace/pull/5014, https://github.com/ajaxorg/ace/pull/5222.
If for any reason creating a PR is not an option for you, please proceed with filling out this issue. Thanks!
- type: input
id: name
attributes:
label: Project name
description: A name of the project to be used on Ace website.
validations:
required: true
- type: input
id: project-link
attributes:
label: Project link
description: A link to the project's website.
validations:
required: true
- type: input
id: logo-link
attributes:
label: Logo link
description: |
A link to the logo image to be used on the website for the project. If not provided, only the name of the project will be displayed.

By submitting this link, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
validations:
required: false
- type: textarea
id: info
attributes:
label: Additional information
description: Any additional information you would like to share.
validations:
required: false
- type: checkboxes
id: ack
attributes:
label: Acknowledgements
options:
- label: I may be able to implement this request.
required: false
3 changes: 1 addition & 2 deletions Makefile.dryice.js
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@
source = source.replace(/( |^)require\(/gm, "$1ace.require(");
}
source = source.replace(/"\.\.\/build\//g, function(e) {
console.log(e); return '"../';
return '"../';
});
return source;
}
Expand Down Expand Up @@ -496,7 +496,7 @@
}

function buildAce(options, callback) {
var snippetFiles = jsFileList("lib/ace/snippets");

Check warning on line 499 in Makefile.dryice.js

View workflow job for this annotation

GitHub Actions / build (16.x)

'snippetFiles' is assigned a value but never used
var modeNames = modeList();

buildCore(options, {outputFile: "ace.js"}, addCb());
Expand Down Expand Up @@ -668,7 +668,6 @@
else
imageName = name + "-" + imageCounter + ".png";
images[imageName] = buffer;
console.log("url(\"" + directory + "/" + imageName + "\")");
return "url(\"" + directory + "/" + imageName + "\")";
}
);
Expand Down Expand Up @@ -882,7 +881,7 @@
});
}

function generateThemesModule(themes) {

Check warning on line 884 in Makefile.dryice.js

View workflow job for this annotation

GitHub Actions / build (16.x)

'generateThemesModule' is defined but never used
var themelist = [
'define(function(require, exports, module) {',
'\n\nmodule.exports.themes = ' + JSON.stringify(themes, null, ' '),
Expand Down
Loading